fix image publisher remapping #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeferguson
commented
Feb 12, 2024
| @@ -56,10 +56,14 @@ DebayerNode::DebayerNode(const rclcpp::NodeOptions & options) | |||
| // TransportHints does not actually declare the parameter | |||
| this->declare_parameter<std::string>("image_transport", "raw"); | |||
|
|
|||
| debayer_ = this->declare_parameter("debayer", 3); | |||
There was a problem hiding this comment.
slightly unrelated fix - but I noticed this parameter gets declared after we create publisher (and publisher callback) - so I moved this up with other parameters
ahcorde
approved these changes
Feb 12, 2024
Kotochleb
pushed a commit
to Kotochleb/image_pipeline
that referenced
this pull request
May 27, 2024
Addresses ros-perception#940 - fixes the compressed/etc topic remapping for publishers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #940 - fixes the compressed/etc topic remapping for publishers